Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-bar): flip rtl using the existing reversed property #17464

Merged
merged 9 commits into from Mar 25, 2019

Conversation

Projects
None yet
2 participants
@brandyscarney
Copy link
Member

commented Feb 11, 2019

Short description of what this resolves:

Updates the progress bar to always use the ltr dir but take advantage of the reversed property when dir is rtl.

references #17012

brandyscarney added some commits Feb 11, 2019

@abennouna

This comment has been minimized.

Copy link
Contributor

commented Feb 13, 2019

@brandyscarney should I close #17382?

brandyscarney added some commits Feb 13, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

@abennouna Yeah I think so. Does this PR work for you or do you see any issues with it?

@abennouna

This comment has been minimized.

Copy link
Contributor

commented Mar 24, 2019

@brandyscarney sorry for the delay; just ran the 3 included tests in both MD and iOS, in both RTL and LTR, everything's works just fine :-)

@brandyscarney brandyscarney merged commit fccaaf8 into master Mar 25, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-progress-rtl branch Mar 25, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(progress-bar): flip rtl using the existing reversed property (ion…
…ic-team#17464)

updates the progress bar to always use the ltr dir but take advantage of the reversed property when dir is rtl.

references ionic-team#17012

@abennouna abennouna referenced this pull request May 22, 2019

Open

Ionic 4.0.0 RTL issues #17012

103 of 110 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.