Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(reorder): increase gesture priority #17568

Merged

Conversation

Projects
None yet
2 participants
@sbannigan
Copy link
Contributor

commented Feb 21, 2019

Short description of what this resolves:

Allow ion-item-sliding items to be reordered inside an ion-reorder-group.

Changes proposed in this pull request:

  • Increase the gesturePriority of ion-reorder-group from 100 to 110.
  • Add a test case for ion-item-sliding in the reorder-group basic test.

I'm not sure if there is a reason this was lower priority than ion-item-sliding before, but this seems to resolve the issue.

Ionic Version: 4.0.2

Fixes: #16120

@sbannigan sbannigan force-pushed the sbannigan:fix/ion-reorder-group-item-sliding branch from 840cfbd to 8e53f9c Feb 22, 2019

fix(reorder): increase gesture priority
 to allow item-sliding items to be reordered

@sbannigan sbannigan force-pushed the sbannigan:fix/ion-reorder-group-item-sliding branch from 8e53f9c to 6e7fa8a Feb 22, 2019

@liamdebeasi
Copy link
Member

left a comment

Great job! Thanks for submitting this! 🎉

@liamdebeasi liamdebeasi merged commit 3b331b5 into ionic-team:master Feb 22, 2019

1 check passed

build Workflow: build
Details

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.