Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item-sliding): no longer closes all open items when deleting and item #17579

merged 6 commits into from Feb 28, 2019


None yet
2 participants
Copy link

commented Feb 22, 2019

Short description of what this resolves:

This PR fixes a corner case that was missed in #17492. The fix closed all open items, since that reset ; openSlidingItem however, it assumed that the open item was always going to be the item that was deleted, which is not necessarily correct. This PR now only resets the openSlidingItem variable if it is the item that is being deleted.

Changes proposed in this pull request:

  • Remove closeOpened call when componentDidUnload is fired
  • Check if openSlidingItem equals the element that was just removed. If it is, set openSlidingItem = undefined

Ionic Version:

Fixes: #17575

liamdebeasi added some commits Feb 22, 2019

@liamdebeasi liamdebeasi requested a review from brandyscarney Feb 22, 2019

liamdebeasi and others added some commits Feb 26, 2019

@liamdebeasi liamdebeasi merged commit 3de7795 into master Feb 28, 2019

2 checks passed

build Workflow: build
screenshot Screenshot

@liamdebeasi liamdebeasi deleted the fix-item-sliding-open branch Feb 28, 2019

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

fix(item-sliding): no longer close all open items when deleting an it…
…em (ionic-team#17579)

* fix auto close items when deleting an item, remove extra click

* lint file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.