Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): ng-add throws when not run against Angular CLI's initia… #17597

Merged
merged 3 commits into from Feb 27, 2019

Conversation

Projects
None yet
3 participants
@ahasall
Copy link
Contributor

commented Feb 24, 2019

…l app

closes #17596

Short description of what this resolves:

See #17596

Changes proposed in this pull request:

  • the location of the root module is parameterized

Ionic Version:

Fixes: #17596

@ahasall ahasall force-pushed the ahasall:fix-ng-add-import-root-module branch from 9e79cae to 0c11324 Feb 25, 2019

@mhartington
Copy link
Member

left a comment

LGTM!

liamdebeasi added some commits Feb 27, 2019

@liamdebeasi liamdebeasi merged commit 484d92c into ionic-team:master Feb 27, 2019

1 check passed

build Workflow: build
Details
@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Feb 27, 2019

Thanks for the PR! 🎉

@ahasall

This comment has been minimized.

Copy link
Contributor Author

commented Feb 27, 2019

You're welcome.

@ahasall ahasall deleted the ahasall:fix-ng-add-import-root-module branch Feb 27, 2019

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.