Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(fab): disabled fab button no longer opens fab list #17620

Merged
merged 5 commits into from Mar 1, 2019

Conversation

Projects
None yet
2 participants
@liamdebeasi
Copy link
Member

commented Feb 26, 2019

Short description of what this resolves:

This PR fixes an issue where the fab list was being opened even when ion-fab-button was disabled.

Changes proposed in this pull request:

  • Check to see if ion-fab-button is disabled before activating list
  • Added tests to make sure this doesn't come back as a regression

Ionic Version:

Fixes: #17599

liamdebeasi and others added some commits Feb 26, 2019

@liamdebeasi liamdebeasi merged commit c475dab into master Mar 1, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-disabled-fab branch Mar 1, 2019

KillerCodeMonkey added a commit to KillerCodeMonkey/ionic that referenced this pull request Mar 1, 2019

fix(fab): disabled fab button no longer opens fab list (ionic-team#17620
)

* fix(fab): disabled fab no longer opens, added tests

* chore(): change FAB to Fab

* update fab name in tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.