Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(popover): update animation origin in RTL/MD #17645

Merged
merged 41 commits into from Mar 15, 2019

Conversation

Projects
None yet
2 participants
@abennouna
Copy link
Contributor

commented Mar 1, 2019

Short description of what this resolves:

In case the popover position is adjusted because it is off screen, the RTL animation should be inverted as well.

Changes proposed in this pull request:

  • Original main-axis origin fix was flawed in case of RTL.
  • Invert the animation’s main-axis origin in case the popover’s position is adjusted.

Ionic Version:
4.x

Fixes: #17012 + #17381

abennouna added some commits Dec 14, 2018

Merge pull request #1 from ionic-team/master
chore(): update to latest master
Merge pull request #2 from ionic-team/master
Merge pull request #2 from ionic-team/master

abennouna and others added some commits Feb 26, 2019

@ionitron-bot ionitron-bot bot added the package: core label Mar 1, 2019

@abennouna abennouna changed the title fix(popover): update animation origin in RTL/MD fix(popover): update animation origin in MD Mar 1, 2019

@abennouna abennouna changed the title fix(popover): update animation origin in MD fix(popover): update animation origin in RTL/MD Mar 1, 2019

abennouna and others added some commits Mar 5, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Looks great, thank you! Good to merge once the build passes. 👍

@brandyscarney brandyscarney merged commit 617453b into ionic-team:master Mar 15, 2019

1 check passed

build Workflow: build
Details

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this pull request Mar 16, 2019

fix(popover): update animation origin in RTL/MD (ionic-team#17645)
Original main-axis origin fix was flawed in case of RTL.
Invert the animation’s main-axis origin in case the popover’s position is adjusted.

references ionic-team#17012

@abennouna abennouna deleted the abennouna:fix-popover-rtl-animation branch Mar 17, 2019

liamdebeasi added a commit that referenced this pull request Mar 19, 2019

liamdebeasi added a commit that referenced this pull request Mar 19, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(popover): update animation origin in RTL/MD (ionic-team#17645)
Original main-axis origin fix was flawed in case of RTL.
Invert the animation’s main-axis origin in case the popover’s position is adjusted.

references ionic-team#17012

@abennouna abennouna referenced this pull request May 22, 2019

Open

Ionic 4.0.0 RTL issues #17012

103 of 110 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.