Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(spinner): fix default spinner logic for relevant components #17660

Merged
merged 47 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@abennouna
Copy link
Contributor

commented Mar 2, 2019

Short description of what this resolves:

Currently, the default spinner icon is using the iOS platform default (lines), even in MD mode, for the following components:

  • refresher
  • infinite-scroll

In addition, the default loading spinner icon logic is not consistent with the above components. It does not try to get the spinner icon from config before falling back to platform default.

Finally, some test templates using the infinite-scroll component are not correctly using the loading spinner and text attributes.

Changes proposed in this pull request:

  • In the loading component, fall back to spinner icon config before platform default.
  • In both refresher & infinite-scroll components, use platform default as final fallback.
  • In infinite-scroll test templates, and the basic virtual-scroll test template, fix loading spinner and text attributes.

Ionic Version: 4.x

Fixes: #17659

abennouna added some commits Dec 14, 2018

Merge pull request #1 from ionic-team/master
chore(): update to latest master
Merge pull request #2 from ionic-team/master
Merge pull request #2 from ionic-team/master

abennouna and others added some commits Feb 26, 2019

@ionitron-bot ionitron-bot bot added the package: core label Mar 2, 2019

liamdebeasi and others added some commits Mar 4, 2019

@brandyscarney brandyscarney requested a review from liamdebeasi Mar 15, 2019

@liamdebeasi
Copy link
Member

left a comment

Great work! 🚀

liamdebeasi and others added some commits Mar 15, 2019

@brandyscarney brandyscarney merged commit 9c48fa7 into ionic-team:master Mar 15, 2019

1 check passed

build Workflow: build
Details
@brandyscarney

This comment has been minimized.

Copy link
Member

commented Mar 15, 2019

Thank you!

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this pull request Mar 16, 2019

fix(spinner): fix default spinner logic for relevant components (ioni…
…c-team#17660)

- In the **`loading`** component, fallback to `spinner` icon config before platform default.
- In both **`refresher`** & **`infinite-scroll`** components, use platform default as final fallback.
- In **`infinite-scroll`** test templates, and the _basic_ **`virtual-scroll`** test template, fix loading _spinner_ and _text_ attributes.

fixes ionic-team#17659

@abennouna abennouna deleted the abennouna:fix-default-spinner-icons branch Mar 17, 2019

liamdebeasi added a commit that referenced this pull request Mar 19, 2019

liamdebeasi added a commit that referenced this pull request Mar 19, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(spinner): fix default spinner logic for relevant components (ioni…
…c-team#17660)

- In the **`loading`** component, fallback to `spinner` icon config before platform default.
- In both **`refresher`** & **`infinite-scroll`** components, use platform default as final fallback.
- In **`infinite-scroll`** test templates, and the _basic_ **`virtual-scroll`** test template, fix loading _spinner_ and _text_ attributes.

fixes ionic-team#17659
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.