Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datetime): default to local date #17706

Merged
merged 14 commits into from Mar 11, 2019

Conversation

Projects
None yet
2 participants
@liamdebeasi
Copy link
Member

commented Mar 6, 2019

Short description of what this resolves:

This PR fixes an issue where datetimes are not localized to the user's timezone. This PR should fix a number of datetime issues.

Changes proposed in this pull request:

  • Create a UTC-like string that has the hours localized to the user's timezone before generating columns in picker
  • Set timezone offset before passing to convertDataToISO to ensure that function does not attempt to convert timezones by itself
  • Added more tests

Ionic Version:

Fixes: #17587 #16436 #16723

@ionitron-bot ionitron-bot bot added the package: core label Mar 6, 2019

liamdebeasi added some commits Mar 7, 2019

@liamdebeasi liamdebeasi marked this pull request as ready for review Mar 8, 2019

@liamdebeasi liamdebeasi requested a review from adamdbradley Mar 8, 2019

@adamdbradley adamdbradley merged commit bab56e8 into master Mar 11, 2019

1 check passed

build Workflow: build
Details

@adamdbradley adamdbradley deleted the date-fns branch Mar 11, 2019

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this pull request Mar 16, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.