Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item-option): add styling for slots other than icon-only #17711

Merged
merged 15 commits into from Mar 15, 2019

Conversation

Projects
None yet
3 participants
@brandyscarney
Copy link
Member

commented Mar 7, 2019

Styles the item option properly when icons are slotted. This was not working before at all for top and bottom slots.

Also:

  • removes the e2e test from item/sliding in favor of all of them being under item-sliding
  • adds more usage examples for all framewroks
  • updates the styling for an anchor option so that it displays properly
  • updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options
  • updates the interactive e2e test to work locally
  • cleaned up the CSS for start/end icons
  • verified the styles for ben approval 馃挭

Screen Shot 2019-03-11 at 1 20 08 PM

closes #17737 fixes #17402

fix(item-option): add styling for slots other than icon-only
it was not working before this at all, also removes the e2e test from item/sliding in favor of all of them being under item-sliding, and adds JS usage

TODO:
- add e2e test with screenshots of this
- verify / clean up CSS design
- add other usage examples

@brandyscarney brandyscarney marked this pull request as ready for review Mar 11, 2019

@brandyscarney brandyscarney requested review from jthoms1 and liamdebeasi Mar 11, 2019

@liamdebeasi
Copy link
Member

left a comment

This looks really good! Just need to DRY up the test helpers a bit 馃帀

brandyscarney added some commits Mar 15, 2019

test(item-sliding): get interactive test working locally
moves open and close functions to utils
@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Mar 15, 2019

Good to merge once the build passes 馃憤

brandyscarney added some commits Mar 15, 2019

@brandyscarney brandyscarney merged commit 14f758c into master Mar 15, 2019

1 check failed

build Workflow: build
Details

@brandyscarney brandyscarney deleted the docs-item-sliding branch Mar 15, 2019

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this pull request Mar 16, 2019

fix(item-option): add styling for slots other than icon-only (ionic-t鈥
鈥am#17711)

styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots.

- removes the e2e test from item/sliding in favor of all of them being under item-sliding
- adds more usage examples for all frameworks
- updates the styling for an anchor option so that it displays properly
- updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options
- updates the interactive e2e test to work locally
- cleaned up the CSS for start/end icons
- verified the styles for ben approval 馃挭

closes ionic-team#17737 fixes ionic-team#17402

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(item-option): add styling for slots other than icon-only (ionic-t鈥
鈥am#17711)

styles the item option properly when icons are slotted. This was not working before at all for `top` and `bottom` slots.

- removes the e2e test from item/sliding in favor of all of them being under item-sliding
- adds more usage examples for all frameworks
- updates the styling for an anchor option so that it displays properly
- updates the standalone e2e test to take screenshots of the start icon, top icon, and anchor options
- updates the interactive e2e test to work locally
- cleaned up the CSS for start/end icons
- verified the styles for ben approval 馃挭

closes ionic-team#17737 fixes ionic-team#17402
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can鈥檛 perform that action at this time.