Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(range): add ticks attribute #17718

Merged
merged 10 commits into from Mar 26, 2019

Conversation

Projects
None yet
3 participants
@sethlilly
Copy link
Contributor

commented Mar 7, 2019

Short description of what this resolves:

When using range with snaps set to true, ticks are displayed; however, when using the snaps attribute the display of ticks may not always be desired. This PR adds a ticks attribute to range.

Changes proposed in this pull request:

  • Add ticks attribute to range

Ionic Version:

  • 4.x

Fixes: #17717

liamdebeasi and others added some commits Mar 11, 2019

@brandyscarney
Copy link
Member

left a comment

Thanks for the PR! Added a minor request to update the documentation. The code itself looks great at first glance. 🎉

Show resolved Hide resolved core/src/components/range/range.tsx Outdated

@brandyscarney brandyscarney requested a review from liamdebeasi Mar 26, 2019

@liamdebeasi
Copy link
Member

left a comment

Great job! 🎉

brandyscarney and others added some commits Mar 26, 2019

Update core/src/components/range/range.tsx
Added documentation change from @brandyscarney to match `if true` convention

Co-Authored-By: sethlilly <seth.lilly@gmail.com>
@sethlilly

This comment has been minimized.

Copy link
Contributor Author

commented Mar 26, 2019

Thanks, @brandyscarney and @liamdebeasi!

@brandyscarney brandyscarney merged commit 016fa16 into ionic-team:master Mar 26, 2019

1 check passed

build Workflow: build
Details

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.