Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(chip): use transparent outline on color chips #17719

Merged
merged 5 commits into from Mar 15, 2019

Conversation

Projects
None yet
1 participant
@brandyscarney
Copy link
Member

commented Mar 7, 2019

Update to match MD spec so outline has no background, in the future we will want to add an "activated" or "selected" state that fills this in

master fix-chip-outline
master(Galaxy S5) (1) fix-chip-outline(Galaxy S5)

@ionitron-bot ionitron-bot bot added the package: core label Mar 7, 2019

brandyscarney added some commits Mar 11, 2019

@brandyscarney brandyscarney requested a review from liamdebeasi Mar 11, 2019

@brandyscarney brandyscarney merged commit f6783db into master Mar 15, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-chip-outline branch Mar 15, 2019

santoshyadav198613 added a commit to santoshyadav198613/ionic that referenced this pull request Mar 16, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.