Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): overlay.getTop can return undefined #17802

Merged
merged 3 commits into from Mar 21, 2019

Conversation

Projects
None yet
3 participants
@Pierrci
Copy link
Contributor

commented Mar 15, 2019

Short description of what this resolves:

Add undefined to the return type of getTop method in OverlayBaseController

Ionic Version: 4.x

Fixes: #17801

liamdebeasi and others added some commits Mar 21, 2019

@mhartington mhartington merged commit 439b10e into ionic-team:master Mar 21, 2019

1 check passed

build Workflow: build
Details
@mhartington

This comment has been minimized.

Copy link
Member

commented Mar 21, 2019

Thanks for the PR!

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.