Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): add missing ripple color property #17814

Merged
merged 5 commits into from Mar 19, 2019

Conversation

Projects
None yet
2 participants
@brandyscarney
Copy link
Member

commented Mar 18, 2019

Short description of what this resolves:

Adds --ripple-color to item

fixes #17523

@brandyscarney brandyscarney requested a review from liamdebeasi Mar 18, 2019

@liamdebeasi
Copy link
Member

left a comment

When adding the custom class in the item/test/buttons test, the ripple no longer shows up. Removing the class adds the default ripple effect back. Looks like it was supposed to show a pink ripple, but it doesn't seem like that's happening. Tested in Chrome 73

The colors on the monitor in the office are washed so the pink didn't show up 🙃

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Mar 19, 2019

@liamdebeasi Hmm are you sure you were on the branch and looking at an android device? I just tried again and see no issues on Chrome 72 or 73.

@brandyscarney brandyscarney merged commit 807820f into master Mar 19, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-item-ripple branch Mar 19, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.