Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(select): fix options being added async while overlay is open #17860

Merged
merged 9 commits into from Mar 26, 2019

Conversation

Projects
None yet
2 participants
@liamdebeasi
Copy link
Member

commented Mar 22, 2019

Short description of what this resolves:

Fixes an issue where select options were not being updated when loaded asynchronously when the overlay was already open

Changes proposed in this pull request:

  • Repopulate options/inputs for the appropriate overlay when needed

Ionic Version:

Fixes: #15716 #17851

@liamdebeasi liamdebeasi marked this pull request as ready for review Mar 22, 2019

@liamdebeasi liamdebeasi requested a review from brandyscarney Mar 22, 2019

liamdebeasi added some commits Mar 22, 2019

brandyscarney and others added some commits Mar 25, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Mar 26, 2019

@liamdebeasi I added some more examples to the async test of the different interfaces and upped the time. Code looks good to me, great fix!

brandyscarney and others added some commits Mar 26, 2019

@liamdebeasi liamdebeasi merged commit 1ecfcd1 into master Mar 26, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@liamdebeasi liamdebeasi deleted the fix-async-select-options branch Mar 26, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.