Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): ensure tabs are resilient to optional tabs. #17862

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
1 participant
@jthoms1
Copy link
Contributor

commented Mar 22, 2019

This PR fixes issues with IonTabs in Ionic React. If null values were passed to IonTabs it would throw an error.

Fixes: #17778

@jthoms1 jthoms1 merged commit c29f5a6 into master Mar 22, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@jthoms1 jthoms1 deleted the tabs-fix branch Mar 22, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.