Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): account for replaceUrl option #17879

Merged
merged 6 commits into from Mar 29, 2019

Conversation

Projects
None yet
3 participants
@liamdebeasi
Copy link
Member

commented Mar 26, 2019

Short description of what this resolves:

There was an issue where our StackController was not taking into account replaceUrl. So when going from page A->page B->page C (replace url), page B was still in the stack. Going back via ion-back-button from page C would go back to page B, whereas going back from page C via the browser back button would go back to page A.

Changes proposed in this pull request:

  • Check for replaceUrl on current navigation when inserting the new view

Ionic Version:

Fixes: #15181

liamdebeasi added some commits Mar 26, 2019

@liamdebeasi liamdebeasi requested review from manucorporat and mhartington Mar 26, 2019

@KillerCodeMonkey

This comment has been minimized.

Copy link
Contributor

commented Mar 27, 2019

damn i just thought of a PR and now i have to see this one :D.

Nice thing ;)

liamdebeasi added some commits Mar 28, 2019

@mhartington

This comment has been minimized.

Copy link
Member

commented Mar 29, 2019

LGTM, squash and :shipit:

@liamdebeasi liamdebeasi merged commit f2c8db9 into master Mar 29, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@liamdebeasi liamdebeasi deleted the back-button-replace-url branch Apr 3, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.