Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Vue] Update IonVueRouter direction type #17901

Merged
merged 4 commits into from Apr 8, 2019

Conversation

Projects
None yet
2 participants
@michaeltintiuc
Copy link
Contributor

commented Mar 28, 2019

As per our talk with Mike, the router's direction should be using @ionic/core's RouterDirection type.

This allows us to utilize 3 animation directions: forward, back and root.
The latter is used to disable animations during transitions.
This approach is far easier on developers than passing meta props to routes or mutating the ion-vue-router's animated prop (which can still be set to false in order to globally disable animations).

@ionitron-bot ionitron-bot bot added the package: vue label Mar 28, 2019

michaeltintiuc and others added some commits Mar 30, 2019

@mhartington mhartington merged commit fa13173 into ionic-team:master Apr 8, 2019

1 check passed

build Workflow: build
Details

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.