Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item-option): styling and behaviour for disabled item-option #17909

Merged
merged 4 commits into from Mar 28, 2019

Conversation

4 participants
@kelvindart
Copy link
Contributor

commented Mar 28, 2019

Short description of what this resolves:

This fixes the linked bug whereby the disabled attribute was not working on the ion-item-option component. This PR includes the styling and applies the disabled class to the component.

Changes proposed in this pull request:

  • Apply item-option-disabled class to the component.
  • Update styling in SCSS file.
  • Update demo to include disabled option.

Ionic Version: 4.1.2

Fixes: #17905

@liamdebeasi liamdebeasi changed the title feat(item-option): styling and behaviour for disabled item-option fix(item-option): styling and behaviour for disabled item-option Mar 28, 2019

@liamdebeasi
Copy link
Member

left a comment

This looks great! I just pushed an additional test 🙂

@kelvindart

This comment has been minimized.

Copy link
Contributor Author

commented Mar 28, 2019

Hey @liamdebeasi - shoot, I missed that part. Thanks for adding it! 🙂

@liamdebeasi liamdebeasi added this to In progress 🤺 in Ionic Core via automation Mar 28, 2019

@liamdebeasi liamdebeasi merged commit 346ecb2 into ionic-team:master Mar 28, 2019

1 check passed

build Workflow: build
Details

Ionic Core automation moved this from In progress 🤺 to Done 🎉 Mar 28, 2019

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Mar 28, 2019

Thank you! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.