Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
feat(searchbar): add disabled attribute #17935
Thank you for the PR! The code looks good! One question, why was the
I don't think we need these as they are used to pass classes up to a parent component for styling and I don't see toolbar using them. Please correct me if I'm mistaken.
brandyscarney left a comment
I did a pass through and requested some changes. Mostly removing the event emitter. I moved the
I'll have to take a look at the UI but this is looking good! Thanks again!