Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): back button goes back to proper tab #18005

Merged
merged 6 commits into from Apr 10, 2019

Conversation

4 participants
@liamdebeasi
Copy link
Member

commented Apr 9, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #17278 #15216

What is the new behavior?

  • When using ion-back-button, the stack controller will now check to see if there is any savedData in the view. If there is, it will attempt to restore whatever state there was before.

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi added some commits Apr 9, 2019

@liamdebeasi liamdebeasi marked this pull request as ready for review Apr 9, 2019

@liamdebeasi liamdebeasi changed the title fix(angular): back button reactivates proper tab fix(angular): back button goes back to proper tab Apr 9, 2019

@liamdebeasi liamdebeasi added this to In progress 🤺 in Ionic Core via automation Apr 9, 2019

@liamdebeasi liamdebeasi moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Apr 9, 2019

@liamdebeasi liamdebeasi requested review from adamdbradley and mhartington Apr 9, 2019

@mhartington
Copy link
Member

left a comment

LGTM

@frenmanoj
Copy link

left a comment

Nit: Reusing the variable

Show resolved Hide resolved angular/src/directives/navigation/stack-controller.ts Outdated
Update angular/src/directives/navigation/stack-controller.ts
Co-Authored-By: liamdebeasi <liamdebeasi@users.noreply.github.com>

@liamdebeasi liamdebeasi merged commit 52e5a8d into master Apr 10, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Apr 10, 2019

@liamdebeasi liamdebeasi deleted the angular-tab-back-button branch Apr 10, 2019

@pipoa

This comment has been minimized.

Copy link

commented Apr 12, 2019

@liamdebeasi greate work! 🎉🎉🎉
waiting for this for a long long time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.