Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): float label when a value is changed async #18024

Merged
merged 3 commits into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@brandyscarney
Copy link
Member

commented Apr 12, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #17555

What is the new behavior?

Emits styles to the parent item on value change (in the watch) so that the item will get the proper class to float the label

Does this introduce a breaking change?

  • Yes
  • No

Other information

Fixes #17555 and #17559

fix(textarea): float label when a value is changed async
emits styles to the parent item on value change so that the item will get the proper class to float the label

fixes #17555 fixes #17559
@liamdebeasi
Copy link
Member

left a comment

Looks good! Is there a particular reason why the animation for the label isn't being run? Or is it just because the component is being re-rendered?

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

@liamdebeasi What do you mean? I see it running.

@liamdebeasi

This comment has been minimized.

Copy link
Member

commented Apr 12, 2019

Text is loaded in after a timeout, but the label just jumps up instead of animating (the blank part of the gif is when I reload my browser)

ypMQCpYC6y

@brandyscarney

This comment has been minimized.

Copy link
Member Author

commented Apr 12, 2019

@liamdebeasi Maybe try slowing your animations down? I see it animating fine:

To be honest the animation looks bad to me, like it populates the value before the animation is done moving the label. But either way this works the same in an input (which has always worked with value changing) so it isn't new to this pull request.

@brandyscarney brandyscarney merged commit 494991e into master Apr 12, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-textarea-value-change branch Apr 12, 2019

Kiku-git added a commit to Kiku-git/ionic that referenced this pull request May 16, 2019

fix(textarea): float label when a value is changed async (ionic-team#…
…18024)

emits styles to the parent item on value change so that the item will get the proper class to float the label

fixes ionic-team#17555 fixes ionic-team#17559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.