Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
fix(buttons): use theme toolbar colors for default iOS buttons #18191
Pull request checklist
Please check if your PR fulfills the following requirements:
Pull request type
Please check the type of change your PR introduces:
What is the current behavior?
Codepen reproducing the problem: https://codepen.io/brandyscarney/pen/VNoPNj?editors=0110
What is the new behavior?
Does this introduce a breaking change?
The iOS buttons were not using the global theme variables that the material design buttons did use. So in the conference app, for example, if you applied the same global theme variables as md is using, it wouldn't work in iOS. Here's a before & after of this with the following custom variables:
Note that this also has a ton of other custom variables above it for the background/texts.
This PR also fixes some issues I found with buttons inside of toolbars w/ colors: