Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): account for query params and fragments within a string #18356

Merged
merged 2 commits into from May 22, 2019

Conversation

Projects
None yet
1 participant
@liamdebeasi
Copy link
Member

commented May 22, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #18354

What is the new behavior?

  • Use the UrlSerializer instead of the hacky approach

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi added some commits May 22, 2019

@liamdebeasi liamdebeasi changed the base branch from 4.4.x to master May 22, 2019

@liamdebeasi liamdebeasi merged commit b79f68a into master May 22, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@liamdebeasi liamdebeasi deleted the angular-fix branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.