Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item-sliding): use the correct gesture direction and side for rtl #18366

Merged
merged 3 commits into from May 23, 2019

Conversation

Projects
None yet
1 participant
@brandyscarney
Copy link
Member

commented May 23, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The item sliding gesture in RTL was trying to open the opposite side, and the open method was not switching sides based on RTL.

Issue Number: references #17012

What is the new behavior?

  • The open method now checks for RTL and switches the side to open
  • The gesture will drag open the correct side for RTL
  • An e2e test for RTL with the gesture has been added

Does this introduce a breaking change?

  • Yes
  • No

Other information

@brandyscarney brandyscarney referenced this pull request May 23, 2019

Open

Ionic 4.0.0 RTL issues #17012

103 of 110 tasks complete

@brandyscarney brandyscarney merged commit 4545100 into master May 23, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-item-sliding-rtl branch May 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.