Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(button): new button has incorrect size #18395

Merged
merged 8 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@topalavlad
Copy link
Contributor

commented May 27, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

When dynamically adding a new ion-button whose size is undefined to a ion-item or ion-item-divider it uses the default size but it should have the same size as a ion-button added to the template.

Issue Number: #18085

What is the new behavior?

Buttons added dynamically with undefined size to a ion-item or ion-item-divider will have default to small size

Does this introduce a breaking change?

  • Yes
  • No

Other information

topalavlad and others added some commits May 29, 2019

@brandyscarney brandyscarney merged commit a3e23fc into ionic-team:master Jun 10, 2019

1 check passed

build Workflow: build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.