Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(menu-button): add variables for hover and focused states #18434

Merged
merged 3 commits into from May 31, 2019

Conversation

Projects
None yet
1 participant
@brandyscarney
Copy link
Member

commented May 31, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the new behavior?

  • adds css variables for hover / focused states
  • adds styles for background hover and rounds the button
  • updates to match the MD spec for the hover/focus states
  • moves width and height to the host element, making it easier to customize
  • fixes the color so it uses Ionic colors instead of adding color to the icon

references #18279

Does this introduce a breaking change?

  • Yes
  • No

Other information

feat(menu-button): add variables for hover and focused states
updates to match the MD spec, adds styles for background hover and rounds the button, moves width and height to the host element, fixes the color so it uses Ionic colors instead of adding color to the icon

references #18279

brandyscarney added some commits May 31, 2019

@brandyscarney brandyscarney requested review from liamdebeasi and removed request for liamdebeasi May 31, 2019

@brandyscarney brandyscarney merged commit 5ba0aa9 into master May 31, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.