Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(back-button): add variables and support for focused and hover #18451

Merged
merged 7 commits into from Jun 10, 2019

Conversation

Projects
None yet
2 participants
@brandyscarney
Copy link
Member

commented Jun 3, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

also adds e2e tests and adds them to screenshot

Issue Number: references #18279 references #17624 fixes #18465

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

master branch
localhost_3333_src_components_back-button_test_basic(iPhone 6_7_8) (2) localhost_3333_src_components_back-button_test_basic(iPhone 6_7_8)
localhost_3333_src_components_back-button_test_basic(iPhone 6_7_8) (3) localhost_3333_src_components_back-button_test_toolbar(iPhone 6_7_8) (1)
localhost_3333_src_components_back-button_test_basic(Galaxy S5) (1) localhost_3333_src_components_back-button_test_basic(Galaxy S5)
localhost_3333_src_components_back-button_test_basic(Galaxy S5) (2) localhost_3333_src_components_back-button_test_toolbar_ionic_mode=md(Galaxy S5)

|

feat(back-button): add variables and support for focused and hover
also adds e2e tests and adds them to screenshot

references #18279

@ionitron-bot ionitron-bot bot added the package: core label Jun 3, 2019

brandyscarney added some commits Jun 5, 2019

fix(back-button): update MD spacing for back button text
adds a toolbar specific test and updates the basic one

@brandyscarney brandyscarney marked this pull request as ready for review Jun 5, 2019

brandyscarney added some commits Jun 10, 2019

@brandyscarney brandyscarney merged commit 58672fb into master Jun 10, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the feat-back-button-vars branch Jun 10, 2019

abennouna added a commit to abennouna/ionic that referenced this pull request Jun 11, 2019

feat(back-button): add variables and support for focused and hover st…
…ates (ionic-team#18451)

- updates MD spacing for back button text
- also adds e2e tests and adds them to screenshot

references ionic-team#18279 references ionic-team#17624 fixes ionic-team#18465
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.