Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button): add variables for customizing hover #18499

merged 6 commits into from Jun 10, 2019


None yet
2 participants
Copy link

commented Jun 10, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: fixes #17974

What is the new behavior?

  • Adds --background-hover and --color-hover variables to button
  • Styles them to have hover states

Does this introduce a breaking change?

  • Yes
  • No

Other information

brandyscarney added some commits Jun 10, 2019

Copy link

left a comment

🎉 Nice job!

@brandyscarney brandyscarney merged commit 5c5934b into master Jun 10, 2019

2 checks passed

build Workflow: build
screenshot Screenshot

@brandyscarney brandyscarney deleted the feat-button-vars branch Jun 10, 2019

abennouna added a commit to abennouna/ionic that referenced this pull request Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.