Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(item): inherit overflow but default to hidden #18502

Merged
merged 4 commits into from Jun 11, 2019

Conversation

Projects
None yet
3 participants
@brandyscarney
Copy link
Member

commented Jun 10, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: fixes #17670

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

Screen Shot 2019-06-10 at 6 09 49 PM

@brandyscarney brandyscarney requested a review from liamdebeasi Jun 10, 2019

@brandyscarney brandyscarney referenced this pull request Jun 10, 2019

Closed

feat(item): add overflow css variable #18410

5 of 13 tasks complete
@liamdebeasi
Copy link
Member

left a comment

Looks good!

brandyscarney added some commits Jun 11, 2019

@brandyscarney brandyscarney merged commit 8d2a47e into master Jun 11, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@brandyscarney brandyscarney deleted the fix-item-overflow branch Jun 11, 2019

@berengergermain

This comment has been minimized.

Copy link

commented Jun 20, 2019

Hello, just a little question : why the CSS class .input-wrapper is still defined with overflow:hidden ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.