Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(textarea): not working wrap="off" #18508

Merged
merged 3 commits into from Jun 11, 2019

Conversation

Projects
None yet
2 participants
@scrpgil
Copy link
Contributor

commented Jun 11, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

#18495

What is the new behavior?

Line feed is enabled by attaching the following CSS.

ion-textarea {
  white-space: nowrap !important;
}

Does this introduce a breaking change?

  • Yes
  • [x ] No

Other information

scrpgil and others added some commits Jun 11, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

Thank you! It looks great. I added a test and will merge this when the build passes. 🎉

@brandyscarney brandyscarney merged commit a583902 into ionic-team:master Jun 11, 2019

1 check passed

build Workflow: build
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.