Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nav-link): merge nav-push/pop/set-root into a single component #18909

Merged
merged 12 commits into from Aug 27, 2019

Conversation

@manucorporat
Copy link
Member

commented Jul 26, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: closes #18933

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

wip
wip

@manucorporat manucorporat marked this pull request as ready for review Aug 27, 2019

@@ -0,0 +1,21 @@
# ion-nav-push

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
# ion-nav-push
# ion-nav-link
@@ -0,0 +1,21 @@
# ion-nav-push

`NavPush` is a component used to navigate to the specified component.

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
`NavPush` is a component used to navigate to the specified component.
A navigation link is used to navigate to a specified component. The component can be navigated to by going `forward`, `back` or as a `root` component.
# ion-nav-push

`NavPush` is a component used to navigate to the specified component.
It is the element form of `NavController.push()`

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
It is the element form of `NavController.push()`
It is the element form of calling the `push()`, `pop()`, and `setRoot()` methods on the navigation controller.
@Element() el!: HTMLElement;

/**
* Component to navigate to. Only used if the `routerDirection` is `forward` or `root`.

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* Component to navigate to. Only used if the `routerDirection` is `forward` or `root`.
* Component to navigate to. Only used if the `routerDirection` is `"forward"` or `"root"`.
@Prop() component?: NavComponent;

/**
* Data you want to pass to the component as props. Only used if the `routerDirection` is `forward` or `root`.

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* Data you want to pass to the component as props. Only used if the `routerDirection` is `forward` or `root`.
* Data you want to pass to the component as props. Only used if the `routerDirection` is `"forward"` or `"root"`.
@Prop() componentProps?: ComponentProps;

/**
* It specifies the transition direction when navigating to another page.

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* It specifies the transition direction when navigating to another page.
* The transition direction when navigating to another page.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { OverlayController, ToastOptions } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `toastController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `toastController` exported from core
* @deprecated Use the `toastController` exported from core.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { ComponentRef, OverlayController, PopoverOptions } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `popoverController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `popoverController` exported from core
* @deprecated Use the `popoverController` exported from core.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { OverlayController, PickerOptions } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `pickerController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `pickerController` exported from core
* @deprecated Use the `pickerController` exported from core.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { ComponentRef, ModalOptions, OverlayController } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `modalController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `modalController` exported from core
* @deprecated Use the `modalController` exported from core.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { LoadingOptions, OverlayController } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `loadingController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `loadingController` exported from core
* @deprecated Use the `loadingController` exported from core.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { AlertOptions, OverlayController } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `alertController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `alertController` exported from core
* @deprecated Use the `alertController` exported from core.
@@ -3,6 +3,9 @@ import { Build, Component, ComponentInterface, Method } from '@stencil/core';
import { ActionSheetOptions, OverlayController } from '../../interface';
import { createOverlay, dismissOverlay, getOverlay } from '../../utils/overlays';

/**
* @deprecated Use the `actionSheetController` exported from core

This comment has been minimized.

Copy link
@brandyscarney

brandyscarney Aug 27, 2019

Member
Suggested change
* @deprecated Use the `actionSheetController` exported from core
* @deprecated Use the `actionSheetController` exported from core.

@manucorporat manucorporat merged commit c3044f5 into master Aug 27, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@manucorporat manucorporat deleted the feat-nav-link branch Aug 27, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.