Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(animation): Ionic Animation utility #18918

Merged
merged 100 commits into from Aug 12, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Jul 26, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

core/src/utils/animation/animation-utils.ts Outdated Show resolved Hide resolved
const offset = keyframe.offset;

const frameString = [];
for (const property in keyframe) {

This comment has been minimized.

Copy link
@manucorporat

manucorporat Jul 26, 2019

Member

Object.keys()?

const existingStylesheet = rootNode.querySelector(`#${stylesheetId}`);
if (existingStylesheet) { return; }

styleContainer.appendChild(stylesheet);

This comment has been minimized.

Copy link
@manucorporat

manucorporat Jul 26, 2019

Member

if we appendChild() maybe we should call the funcion add() instead of create()? just a though

core/src/utils/animation/animation.ts Outdated Show resolved Hide resolved
* before the animation begins.
*/
const beforeRemoveClass = (className: string | string[] | undefined): Animation => {
beforeRemoveClasses = addClassToArray(beforeRemoveClasses, className);

This comment has been minimized.

Copy link
@manucorporat

manucorporat Jul 26, 2019

Member

wonder if we can use something like

beforeRemoveClasses.push(...parseClassname(className))
core/src/utils/animation/animation.ts Outdated Show resolved Hide resolved
core/src/utils/animation/animation.ts Outdated Show resolved Hide resolved
core/src/utils/animation/animation.ts Outdated Show resolved Hide resolved
core/src/utils/animation/animation.ts Outdated Show resolved Hide resolved
core/src/utils/animation/animation.ts Outdated Show resolved Hide resolved
liamdebeasi added 12 commits Aug 8, 2019
Copy link

left a comment

Make all needed changes. Ready for elevation. Next level up.

Copy link

left a comment

approved

@liamdebeasi liamdebeasi merged commit 30ca46a into master Aug 12, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the feat-animation branch Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.