Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(toggle): change background to use CSS variable #19012

Merged
merged 13 commits into from Aug 12, 2019

Conversation

@sethlilly
Copy link
Contributor

commented Aug 6, 2019

Short description of what this resolves:

Background color for ion-toggle is now properly set in iOS mode.

Changes proposed in this pull request:

  • Change .toggle-icon property background-color to background for consistency with checked state and the .toggle-inner background property
  • Change background property to use CSS variable

Ionic Version:

  • 4.7.0
  • 4.7.1

Fixes: #18940

sethlilly and others added 13 commits Mar 7, 2019
Update core/src/components/range/range.tsx
Added documentation change from @brandyscarney to match `if true` convention

Co-Authored-By: sethlilly <seth.lilly@gmail.com>
Seth Lilly
Seth Lilly

@ionitron-bot ionitron-bot bot added the package: core label Aug 6, 2019

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thanks for the PR! This is good to merge when the build passes. 🎉

Edited to add: there's nothing you need to do to make the build pass, I re-ran the build!

@brandyscarney brandyscarney merged commit 94e525c into ionic-team:master Aug 12, 2019

1 check passed

build Workflow: build
Details
@brandyscarney

This comment has been minimized.

Copy link
Member

commented Aug 12, 2019

Thank you again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.