Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): set correct electron reg ex #19044

Merged
merged 2 commits into from Aug 8, 2019

Conversation

@robingenz
Copy link
Contributor

commented Aug 8, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19043

What is the new behavior?

Electron is now recognized as a platform.

Does this introduce a breaking change?

  • Yes
  • No
Robin Genz

@ionitron-bot ionitron-bot bot added the package: core label Aug 8, 2019

core/src/utils/platform.ts Outdated Show resolved Hide resolved
Update core/src/utils/platform.ts
apply case insensitive expression flag

Co-Authored-By: Manu MA <manu.valladolid@gmail.com>

@manucorporat manucorporat merged commit e8cdda0 into ionic-team:master Aug 8, 2019

1 check passed

build Workflow: build
Details
@manucorporat

This comment has been minimized.

Copy link
Member

commented Aug 8, 2019

Thanks a lot for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.