Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(swiper): expose full API #19137

Merged
merged 4 commits into from Aug 27, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Aug 20, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

The full swiper api was never publicly exposed, so every time a user wanted to access the swiper API, we had to expose a new method.

What is the new behavior?

Exposed the raw swiper API, so users can access all parts of its API.

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi added 3 commits Aug 27, 2019

@liamdebeasi liamdebeasi marked this pull request as ready for review Aug 27, 2019

@manucorporat
Copy link
Member

left a comment

ship it!

@liamdebeasi liamdebeasi merged commit e1fa461 into master Aug 27, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@liamdebeasi liamdebeasi deleted the swiper branch Aug 27, 2019

brandyscarney added a commit that referenced this pull request Aug 30, 2019
feat(swiper): expose full API (#19137)
* expose full swiper API

* update types

* run build

* run angular build
@daem0ndev

This comment has been minimized.

Copy link
Contributor

commented Sep 4, 2019

sooo appreciated! thanks team!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.