Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animation): add correct `onFinish` interface parameters #19199

Merged
merged 1 commit into from Sep 3, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Aug 27, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

onFinish interface did not show the opts parameter and did not show the correct callback type.

What is the new behavior?

Added opts parameter and corrected the callback type.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi merged commit a81653b into master Sep 3, 2019

1 of 2 checks passed

screenshot Screenshot
Details
build Workflow: build
Details

@liamdebeasi liamdebeasi deleted the on-finish-api branch Sep 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.