Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animation): better feature detection #19212

Merged
merged 3 commits into from Aug 28, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Aug 28, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

External libraries such as google maps was adding a type of polyfill to window.Animation which was causing animations to break when loading those external libraries

What is the new behavior?

Switched to checking the Element's prototype for support

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi added 2 commits Aug 28, 2019

@liamdebeasi liamdebeasi merged commit 6eca5b0 into master Aug 28, 2019

2 checks passed

build Workflow: build
Details
screenshot Screenshot
Details

@liamdebeasi liamdebeasi deleted the animation-feature-detection branch Aug 28, 2019

brandyscarney added a commit that referenced this pull request Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.