Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(title): add support for small title #19215

Merged
merged 19 commits into from Sep 5, 2019

Conversation

@brandyscarney
Copy link
Member

commented Aug 28, 2019

Ready to Merge

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: closes #18898

What is the new behavior?

  • Adds support for small size in title
  • Updates styles on the toolbar / searchbar for iOS 13

Screen Shot 2019-08-28 at 4 01 10 PM

master branch
ios master sizes ios branch sizes
md master sizes md branch sizes

Does this introduce a breaking change?

  • Yes
  • No

Other information

Usage information:

<ion-header>
  <ion-toolbar>
    <ion-title size="small">Choose a contact to add to Favorites</ion-title>
  </ion-toolbar>
  <ion-toolbar>
    <ion-title>Contacts</ion-title>
    <ion-buttons slot="end">
      <ion-button>Cancel</ion-button>
    </ion-buttons>
  </ion-toolbar>
  <ion-toolbar>
    <ion-searchbar></ion-searchbar>
  </ion-toolbar>
</ion-header>
core/src/components/searchbar/searchbar.tsx Outdated Show resolved Hide resolved
core/src/components/segment/segment.tsx Show resolved Hide resolved
core/src/components/title/test/sizes/e2e.ts Outdated Show resolved Hide resolved
core/src/components/title/test/sizes/e2e.ts Outdated Show resolved Hide resolved
core/src/components/title/title.tsx Outdated Show resolved Hide resolved
@brandyscarney brandyscarney changed the base branch from next to master Aug 30, 2019
@brandyscarney brandyscarney force-pushed the feat-header-note branch from c94f5cf to 7d0e90c Aug 30, 2019
@brandyscarney brandyscarney requested a review from manucorporat Aug 30, 2019
@brandyscarney brandyscarney merged commit e27962d into master Sep 5, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@brandyscarney brandyscarney deleted the feat-header-note branch Sep 5, 2019
brandyscarney added a commit that referenced this pull request Sep 16, 2019
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
brandyscarney added a commit that referenced this pull request Oct 2, 2019
Updates title to include `small` size and updates searchbar and UI to match native.

closes #18898
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.