Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(platform): properly detect iPads running iPadOS #19258

Merged
merged 3 commits into from Sep 12, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Sep 3, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Platform detection does not correctly detect iOS devices running iPadOS, causing those devices to launch in MD mode

What is the new behavior?

Platform detection can now detect iOS devices running iPadOS

Does this introduce a breaking change?

  • Yes
  • No

Other information

liamdebeasi added 2 commits Sep 3, 2019
@ionitron-bot ionitron-bot bot added the package: core label Sep 3, 2019
@liamdebeasi liamdebeasi requested a review from adamdbradley Sep 3, 2019
}

// iOS 13+
if (testUserAgent(win, /Macintosh/i) && isMobile(win)) {

This comment has been minimized.

Copy link
@manucorporat

manucorporat Sep 4, 2019

Member

wondering if we can use some JS media query?

@brandyscarney brandyscarney added this to In progress 🤺 in Ionic Core via automation Sep 6, 2019
@brandyscarney brandyscarney moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Sep 6, 2019
@rossholdway

This comment has been minimized.

Copy link
Contributor

commented Sep 11, 2019

With iPadOS out this month, are you planning to get this fix into v4.10.0? I’m sure many of us will be pushing updates for iOS/iPadOS 13 and it’d be great to be able to test / have the correct styling before then 🙂

@liamdebeasi liamdebeasi merged commit aec2936 into master Sep 12, 2019
1 of 2 checks passed
1 of 2 checks passed
screenshot Screenshot
Details
build Workflow: build
Details
Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Sep 12, 2019
@liamdebeasi liamdebeasi deleted the ipados branch Sep 12, 2019
@liamdebeasi

This comment has been minimized.

Copy link
Member Author

commented Sep 12, 2019

This will be available in the next release of Ionic 🙂

brandyscarney added a commit that referenced this pull request Sep 16, 2019
* Add support for iPadOS

* add better test

* small tweak
liamdebeasi added a commit that referenced this pull request Sep 16, 2019
* Add support for iPadOS

* add better test

* small tweak
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ionic Core
  
Done 🎉
3 participants
You can’t perform that action at this time.