Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(title): add large iOS toolbar title #19268

Merged
merged 73 commits into from Sep 4, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Sep 4, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #16885

What is the new behavior?

Adds the iOS 11 header design.

Does this introduce a breaking change?

  • Yes
  • No

Other information

brandyscarney and others added 30 commits Apr 2, 2019
…rgin, account for large title in navigation transitions
liamdebeasi added 21 commits Aug 28, 2019
@liamdebeasi liamdebeasi merged commit 923312e into master Sep 4, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the feat-ios-toolbar branch Sep 4, 2019
brandyscarney added a commit that referenced this pull request Sep 16, 2019
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
brandyscarney added a commit that referenced this pull request Oct 2, 2019
Co-authored-by: Brandy Carney <brandyscarney@users.noreply.github.com>
@mutatedplague

This comment has been minimized.

Copy link

commented Oct 8, 2019

So how do I implement the large toolbar looking through the merge i cant seem to find how to enable it

@liamdebeasi

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.