Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animation): fallback to CSS Animations on older versions of Chrome #19288

Merged
merged 1 commit into from Sep 10, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Sep 6, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19272
Methods like updateTiming and getComputedTiming actually shipped in Chrome 75, not earlier like I had originally thought. For the most part, people should have autoupdating Chrome (and so this shouldn't be an issue), but some either do not have autoupdating enabled or the autoupdating hasn't kicked in yet for whatever reason. As a result, they were running into this issue since older versions of Chrome only had a partial implementation of Web Animations.

What is the new behavior?

  • Improve the feature detection to look for AnimationEffect support, which should cover the rest of the APIs we use.

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core label Sep 6, 2019
@liamdebeasi liamdebeasi merged commit 2d39c07 into master Sep 10, 2019
1 of 2 checks passed
1 of 2 checks passed
screenshot Screenshot
Details
build Workflow: build
Details
@liamdebeasi liamdebeasi deleted the animation-chrome-old branch Sep 10, 2019
@daem0ndev

This comment has been minimized.

Copy link
Contributor

commented Sep 13, 2019

Thx @liamdebeasi you are a beast! 💙

@cgossett

This comment has been minimized.

Copy link

commented Sep 13, 2019

Agreed, thank you sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.