Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(animation): set defaults to avoid inconsistencies #19321

Merged
merged 2 commits into from Sep 11, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Sep 10, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

There are a few inconsistencies between Web and CSS Animations. For example, the default easing in css animations is ease, but in web animations the default easing is linear

What is the new behavior?

Set defaults to avoid any inconsistencies between web and css anims

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested a review from manucorporat Sep 10, 2019
@liamdebeasi liamdebeasi merged commit 1cbb52c into master Sep 11, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the animation-defaults branch Sep 11, 2019
brandyscarney added a commit that referenced this pull request Sep 16, 2019
* set defaults to avoid inconsistencies

* update test
brandyscarney added a commit that referenced this pull request Oct 2, 2019
* set defaults to avoid inconsistencies

* update test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.