Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(animation): avoid ngzone with requestAnimationFrame #19457

Merged
merged 2 commits into from Sep 26, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Sep 26, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Our raf calls did were not using the patched version of raf, so ngzone would have run during animations causing a lot of jank

What is the new behavior?

  • updated animations to use a patched version of raf that prevents ngzone from being called

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi merged commit 8ca97ce into master Sep 26, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the zone-animation branch Sep 26, 2019
brandyscarney added a commit that referenced this pull request Oct 2, 2019
* add patched zone for animations

* minify raf better
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.