Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(content): overscroll only in iOS #19470

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@manucorporat
Copy link
Member

commented Sep 27, 2019

fixes #19465

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

fixes #19465
@liamdebeasi liamdebeasi added this to In progress 🤺 in Ionic Core via automation Sep 27, 2019
@liamdebeasi liamdebeasi moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Sep 27, 2019
@liamdebeasi liamdebeasi moved this from Needs review 🤔 to Ready to Merge 🚀 in Ionic Core Oct 7, 2019
@liamdebeasi liamdebeasi merged commit bb32cea into master Oct 8, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
Ionic Core automation moved this from Ready to Merge 🚀 to Done 🎉 Oct 8, 2019
@liamdebeasi liamdebeasi deleted the fix-content-overscroll branch Oct 8, 2019
liamdebeasi added a commit that referenced this pull request Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ionic Core
  
Done 🎉
2 participants
You can’t perform that action at this time.