Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(header): fix collapsing iOS header when using with split pane #19480

Merged
merged 2 commits into from Oct 4, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Sep 27, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19541

What is the new behavior?

  1. Check the correct bounding box in the IO handler
  2. Account for any left/right offsets when doing nav transitions

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi requested review from brandyscarney and mhartington Oct 2, 2019
@brandyscarney

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

Released dev build for this 4.11.0-dev.201910021714.944a660 cc @mhartington

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Oct 2, 2019

I'm still seeing this 🤔

@liamdebeasi

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

@brandyscarney Are you testing the dev build above? I'm testing it on your conference app changes and everything looks like it's working fine

@liamdebeasi

This comment has been minimized.

Copy link
Member Author

commented Oct 3, 2019

Ok I tagged the wrong issue. Updated with correct issue

@brandyscarney

This comment has been minimized.

Copy link
Member

commented Oct 4, 2019

Okay perfect, testing the right issue out and this is fixed! 🎉

@brandyscarney brandyscarney added this to In progress 🤺 in Ionic Core via automation Oct 4, 2019
@brandyscarney brandyscarney moved this from In progress 🤺 to Ready to Merge 🚀 in Ionic Core Oct 4, 2019
@liamdebeasi liamdebeasi merged commit dea1c26 into master Oct 4, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
Ionic Core automation moved this from Ready to Merge 🚀 to Done 🎉 Oct 4, 2019
@liamdebeasi liamdebeasi deleted the header-split-pane branch Oct 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ionic Core
  
Done 🎉
2 participants
You can’t perform that action at this time.