Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(list): add bottom border for first item in inset list #19525

merged 1 commit into from Oct 2, 2019


Copy link

commented Oct 2, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19507

What is the new behavior?

  • Revised the CSS logic so that the first item has a bottom border but not a top border

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core label Oct 2, 2019
@liamdebeasi liamdebeasi requested a review from brandyscarney Oct 2, 2019
@liamdebeasi liamdebeasi added this to In progress 🤺 in Ionic Core via automation Oct 2, 2019
@liamdebeasi liamdebeasi moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Oct 2, 2019
Copy link

left a comment


@liamdebeasi liamdebeasi merged commit 71b8853 into master Oct 2, 2019
2 checks passed
2 checks passed
build Workflow: build
screenshot Screenshot
Ionic Core automation moved this from Needs review 🤔 to Done 🎉 Oct 2, 2019
@liamdebeasi liamdebeasi deleted the item-underline branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Ionic Core
Done 🎉
2 participants
You can’t perform that action at this time.