Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(css): update deprecations to remove wrap #19535

Merged
merged 1 commit into from Oct 2, 2019

Conversation

@brandyscarney
Copy link
Member

commented Oct 2, 2019

the wrap attribute is still deprecated from global CSS but it improperly throws errors on textarea where it's valid

fixes #19499

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this introduce a breaking change?

  • Yes
  • No

Other information

the wrap attribute is still deprecated from global CSS but it improperly throws errors on textarea where it's valid

fixes #19499
@brandyscarney brandyscarney added this to In progress 🤺 in Ionic Core via automation Oct 2, 2019
@brandyscarney brandyscarney moved this from In progress 🤺 to Needs review 🤔 in Ionic Core Oct 2, 2019
@brandyscarney brandyscarney moved this from Needs review 🤔 to Ready to Merge 🚀 in Ionic Core Oct 2, 2019
@brandyscarney brandyscarney merged commit bfb704e into master Oct 2, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
Ionic Core automation moved this from Ready to Merge 🚀 to Done 🎉 Oct 2, 2019
@brandyscarney brandyscarney deleted the fix-css-deprecations branch Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Ionic Core
  
Done 🎉
1 participant
You can’t perform that action at this time.