Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(overlay): ensure lifecycles fire properly #19579

Merged
merged 1 commit into from Oct 8, 2019

Conversation

@liamdebeasi
Copy link
Member

commented Oct 8, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #19576

What is the new behavior?

  • Fixed bug to ensure lifecycles are called
  • Added tests so this bug doesn't happen again

Does this introduce a breaking change?

  • Yes
  • No

Other information

@liamdebeasi liamdebeasi merged commit a7b9642 into release-4.10.2 Oct 8, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@liamdebeasi liamdebeasi deleted the fix-modal-lifecycle branch Oct 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.