Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(searchbar): update alignment of chips and other elements in toolbar #19596

Merged
merged 3 commits into from Oct 8, 2019

Conversation

@brandyscarney
Copy link
Member

commented Oct 8, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: fixes #19495 fixes #19502

What is the new behavior?

  • Moves the CSS to the searchbar to remove !important
  • Aligns all slotted content next to a searchbar to the top and adjusts the chip margin

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core label Oct 8, 2019
@brandyscarney brandyscarney merged commit 7ce916c into master Oct 8, 2019
2 checks passed
2 checks passed
build Workflow: build
Details
screenshot Screenshot
Details
@brandyscarney brandyscarney deleted the fix-searchbar-alignment branch Oct 8, 2019
liamdebeasi added a commit that referenced this pull request Oct 9, 2019
// -----------------------------------------

:host-context(ion-toolbar) {
@include padding(1px, null, 15px, null);

This comment has been minimized.

Copy link
@anagstef

anagstef Oct 16, 2019

Contributor

@brandyscarney Hello! Is this supposed to be 1px for the top padding? Because updating to this version broke all our searchbars in toolbars. If I change it to 15px it works fine as before.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.