Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select): add --placeholder-opacity, expose shadow parts #19893

Merged
merged 5 commits into from Nov 11, 2019

Conversation

liamdebeasi
Copy link
Member

@liamdebeasi liamdebeasi commented Nov 11, 2019

Pull request checklist

Please check if your PR fulfills the following requirements:

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been reviewed and added / updated if needed (for bug fixes / features)
  • Build (npm run build) was run locally and any changes were pushed
  • Lint (npm run lint) has passed locally and any fixes were made for failures

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: #17446

What is the new behavior?

  • Added --placeholder-opacity and --placeholder-color` css variables
  • Added shadow parts for relevant elements

Does this introduce a breaking change?

  • Yes
  • No

Other information

@ionitron-bot ionitron-bot bot added the package: core @ionic/core package label Nov 11, 2019
Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing the UI now

@@ -471,10 +471,10 @@ export class Select implements ComponentInterface {
'select-disabled': disabled,
}}
>
<div class={selectTextClasses}>
<div class={selectTextClasses} part="select-text">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want parts to be prefixed with select? In Segment we just add part="indicator" since the way you will target would be like:

ion-segment::part(indicator)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I removed the prefix

liamdebeasi and others added 2 commits November 11, 2019 12:10
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
Co-Authored-By: Brandy Carney <brandyscarney@users.noreply.github.com>
@liamdebeasi liamdebeasi marked this pull request as ready for review November 11, 2019 17:11
@brandyscarney
Copy link
Member

Approved once changes are made

@gonewayword
Copy link

gonewayword commented Apr 23, 2021

Is this still not working at all for anyone else? I cannot get the color or opacity to change no matter what. I've applied these style variables to the element, parent elements, etc, and no matter what it does not change. Even when the DOM shows it as being there, it's still getting overriden by:

.select-placeholder {
color: currentcolor;
opacity: 0.33;
}

Tried targeting that specific inner div too in a variety of ways, since the shadow dom shows it as "(open)", but nothing either.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: core @ionic/core package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants